Merge pull request #37 from nils-a/feature/GH-23

(GH-23) added options for inline configuration comments
cake-contrib · Jun 10, 2021 · 93d361b · 93d361b
2 parents e25867f + fa08aeb
commit 93d361b
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 0 deletions.
diff --git a/src/Cake.ESLint.Tests/ESLintRunnerTests.cs b/src/Cake.ESLint.Tests/ESLintRunnerTests.cs
@@ -456,6 +456,26 @@ public void Should_add_max_warnings_arg_when_MaxWarnings_is_set()
             actual.Args.ShouldContain("--max-warnings 5");
         }
 
+        [Fact]
+        public void Should_no_inline_config_arg_when_NoInlineConfig_is_set()
+        {
+            fixture.Settings.NoInlineConfig = true;
+
+            var actual = fixture.Run();
+
+            actual.Args.ShouldContain("--no-inline-config");
+        }
+
+        [Fact]
+        public void Should_add_report_unused_disable_directives_arg_when_ReportUnusedDisableDirectives_is_set()
+        {
+            fixture.Settings.ReportUnusedDisableDirectives = true;
+
+            var actual = fixture.Run();
+
+            actual.Args.ShouldContain("--report-unused-disable-directives");
+        }
+
         // ReSharper disable once ClassNeverInstantiated.Local
         private class OutputFormatDataGenerator : IEnumerable<object[]>
         {

diff --git a/src/Cake.ESLint/ESLintRunner.cs b/src/Cake.ESLint/ESLintRunner.cs
@@ -233,6 +233,16 @@ private ProcessArgumentBuilder GetArguments(ESLintSettings settings)
                 builder.AppendSwitch("--max-warnings", settings.MaxWarnings.Value.ToString());
             }
 
+            if (settings.NoInlineConfig)
+            {
+                builder.Append("--no-inline-config");
+            }
+
+            if (settings.ReportUnusedDisableDirectives)
+            {
+                builder.Append("--report-unused-disable-directives");
+            }
+
             // render arguments
             foreach (var file in settings.Files.EnsureNotNull())
             {

diff --git a/src/Cake.ESLint/ESLintSettings.cs b/src/Cake.ESLint/ESLintSettings.cs
@@ -180,6 +180,20 @@ public ESLintSettings()
         /// </summary>
         public int? MaxWarnings { get; set; }
 
+        /// <summary>
+        /// Gets or sets a value indicating whether
+        /// to prevent comments from changing config or rules.
+        /// <para>Option: <c>--no-inline-config</c>.</para>
+        /// </summary>
+        public bool NoInlineConfig { get; set; }
+
+        /// <summary>
+        /// Gets or sets a value indicating whether
+        /// to report errors for unused eslint-disable directives.
+        /// <para>Option: <c>--report-unused-disable-directives</c>.</para>
+        /// </summary>
+        public bool ReportUnusedDisableDirectives { get; set; }
+
         /// <summary>
         /// Gets or sets a value indicating whether to continue on lint errors.
         /// <para>