Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add augustoproiete as a contributor #140

Closed
wants to merge 4 commits into from

Conversation

allcontributors[bot]
Copy link
Contributor

Adds @augustoproiete as a contributor for maintenance.

This was requested by augustoproiete in this comment

@AdmiringWorm
Copy link
Member

@augustoproiete adding as a contribution for maintenance would be wrong in this case, this is for the main maintainers of a repository.

Your contribution falls more in the line of updating documentation.

@all-contributors please add @augustoproiete for doc

@allcontributors
Copy link
Contributor Author

@AdmiringWorm

I've updated the pull request to add @augustoproiete! 🎉

@AdmiringWorm AdmiringWorm deleted the all-contributors/add-augustoproiete branch February 13, 2021 06:23
@AdmiringWorm
Copy link
Member

@all-contributors please add @augustoproiete for doc

@allcontributors
Copy link
Contributor Author

@AdmiringWorm

I've put up a pull request to add @augustoproiete! 🎉

@augustoproiete
Copy link
Member

No worries. I thought maintenance was "chore" which is how I see updating hundreds of READMEs to point to GH Discussions 😄

@AdmiringWorm
Copy link
Member

Completely understandable, and there are probably people that use the maintenance label from allcontributors in that way as well.
Personally, I prefer it to be as distinct as possible, so you added a documentation change and doc would be appropriate then. You have also added an issue with the idea of updating the addin to support Cake 1.0.0, and once that issue is closed a new label would need to be added as well with the idea label (only an icon would be different in the README though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants