Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runner resolves to Windows only binary on unix #310

Closed
AdmiringWorm opened this issue May 4, 2024 · 1 comment · Fixed by #309
Closed

Runner resolves to Windows only binary on unix #310

AdmiringWorm opened this issue May 4, 2024 · 1 comment · Fixed by #309
Assignees
@AdmiringWorm
Labels
Bug
Milestone
2.0.0

Comments

@AdmiringWorm
Copy link
Member

AdmiringWorm commented May 4, 2024 •
edited
Loading

When we attempt to resolve the executable for Codecov, we used to also resolve to codecov.exe. This was fine when the executable used was the Codecov exe project, but now that the only way forward is to use the official binary from Codecov, the exe variant will only run on Windows.

As such, we should only resolve to the exe when running on Windows, but not on any of the unix platforms.

This is mainly a fallback, so it won't be as noticable by existing usage that uses Cake.Codecov v1.1.0.
@AdmiringWorm AdmiringWorm added this to the 2.0.0 milestone May 4, 2024
@AdmiringWorm AdmiringWorm self-assigned this May 4, 2024
AdmiringWorm added a commit that referenced this issue May 4, 2024
@AdmiringWorm
(#310) Resolve windows binary only on windows
5135f28
AdmiringWorm added a commit to AdmiringWorm/Cake.Codecov that referenced this issue May 4, 2024
@AdmiringWorm
(cake-contrib#310) Resolve windows binary only on windows
ad6e231
AdmiringWorm added a commit to AdmiringWorm/Cake.Codecov that referenced this issue May 4, 2024
@AdmiringWorm
(cake-contrib#310) Resolve windows binary only on windows
52c308e
@AdmiringWorm AdmiringWorm mentioned this issue May 4, 2024
Merged
@cake-contrib-bot
Copy link

🎉 This issue has been resolved in version 2.0.0 🎉

The release can be downloaded from:

Your friendly GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdmiringWorm AdmiringWorm

Labels
Bug
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

(#218,#285,#288) Update Cake.Core to v2.0.0 AdmiringWorm/Cake.Codecov
2 participants
@AdmiringWorm @cake-contrib-bot