-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DotNetListPackage alias for dotnet list package command #4229
Conversation
@Marusyk going the JSON route seems like the best option and an object model provides the most value in a Cake context. |
ok, so should we allow only |
Yes, think that makes sense. |
Can someone help me find the model for that json result? Depending on the parameters, the result is different every time. I would like to know all the possible attributes that can be returned and make a model for them. |
Thin it's just a wrapper around NuGet.CommandLine.XPlat which probably means the code is somewhere around here |
Useful: https://github.com/NuGet/Home/blob/dev/accepted/2022/DotnetListPackageMachineReadableJsonOutput.md |
6a588e0
to
a868e9b
Compare
Thanks @Marusyk looking good so far. Some tests are failing. Ping when ready for next round |
thanks @augustoproiete . can you help me? I can't figure out why the tests are failing |
can anyone help me to fix this PR?) |
Rebased against latest, fixed the failing unit tests and integration test (needed to ensure project restored before executing as integration test cleans between tfms). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@Marusyk your changes have been merged, thanks for your contribution 👍 |
Add an alias for
dotnet list package
commandFixes #4224
Here is the basic implementation. I need your suggestion on what we should do with the output.
If the format is
console
we will receive smth like thisIf the format is json, there could be a several different output which is dependent on the input params
when error
If we allow only JSON, then I'll be able to create models and deserialize (for
console
format it is almost impossible) and return the result forpublic ListResult DotNetListPackage(...)
but what if someone just wants to get the output and that's all.What do you think?
Thank you in advance