Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH3879/3880: Scope cache per script host #3881

Merged
merged 2 commits into from
Apr 29, 2022

Conversation

devlead
Copy link
Member

@devlead devlead commented Apr 29, 2022

* Include script host in the cache filename
* Move hash from file to the cache filename
* fixes cake-build#3879
* fixes cake-build#3880
@devlead devlead requested a review from patriksvensson April 29, 2022 07:29
@devlead
Copy link
Member Author

devlead commented Apr 29, 2022

Will need to fix integration tests as filenames are no longer known.

@devlead
Copy link
Member Author

devlead commented Apr 29, 2022

Integration tests should now be adjusted to accommodate adjustments in PR.

@devlead devlead enabled auto-merge April 29, 2022 09:42
Copy link
Member

@patriksvensson patriksvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devlead devlead merged commit 08db227 into cake-build:develop Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants