Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH3545: Add DotNetClean alias (synonym to DotNetCoreClean) #3617

Merged
merged 1 commit into from
Oct 19, 2021
Merged

GH3545: Add DotNetClean alias (synonym to DotNetCoreClean) #3617

merged 1 commit into from
Oct 19, 2021

Conversation

augustoproiete
Copy link
Member

DotNetCore DotNet synonym
DotNetCoreClean ➡️ 🆕 DotNetClean
DotNetCoreCleanSettings ➡️ 🆕 DotNetCleanSettings
  • New DotNetClean aliases are being introduced
  • DotNetClean aliases contain the code of the existing DotNetCoreClean (rename/move)
  • Existing DotNetCoreClean aliases are forwarding calls to newly introduced DotNetClean aliases
  • New DotNetCleanSettings class is being introduced
  • DotNetCleanSettings class contains the code of DotNetCoreCleanSettings (rename/move)
  • The previous DotNetCoreCleanSettings is now empty and inherits from the new DotNetCleanSettings
  • Namespaces Cake.Common.Clean.DotNetCore.* have been preserved as to not introduce breaking changes
  • Unit Tests and Integration Tests remain the same, and call the old DotNetCore*** aliases, exercising the new DotNet*** aliases in the process

Closes #3545

@devlead devlead force-pushed the add-dotnet-clean-alias branch from 8c689c9 to 512d138 Compare October 19, 2021 07:44
devlead
devlead approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead enabled auto-merge October 19, 2021 07:45
@devlead devlead merged commit 5154c09 into cake-build:develop Oct 19, 2021
@devlead devlead deleted the add-dotnet-clean-alias branch October 19, 2021 08:04
@devlead
Copy link
Member

devlead commented Oct 19, 2021

@augustoproiete your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devlead devlead devlead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add DotNetClean alias (synonym to DotNetCoreClean)
2 participants
@augustoproiete @devlead