GH1669: fixed parsing of versions with prerelease #3568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
CI seems to fail due to a file not adhering to certain rules, will fix these accordingly. EDIT: Fixed rules in new class, will check if CI succeeds, Found issue in .cake files, will fix |
devlead
requested changes
Oct 9, 2021
devlead
reviewed
Oct 9, 2021
|
CI now seems to work, sorry for the large number of small commits! was a bit absentminded this morning 😅 |
devlead
force-pushed
the
parse-prerelease
branch
2 times, most recently
from
fc2620f to
3f2e320
Compare
devlead
force-pushed
the
parse-prerelease
branch
from
3f2e320 to
55d8356
Compare
|
@sgronlund your changes have been merged, thanks for your contribution 👍 |
|
@sgronlund If you have a Twitter account and want us to give you a shout out when this gets released, let us know your Twitter handle. |
guera142
reviewed
Jan 3, 2022
| @@ -15,11 +15,23 @@ public sealed class TheConstructor | |||
| public void Should_Throw_If_Version_Is_Null() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1669
Reason for PR
Fixed the parsing of version number which includes prereleases.
Features, i.e. what has been implemented?
Change the ´Version´-class used in the parsing of release notes the another class
SemanticVersion-class written by devlead. This allows theReleaseNotesParserto handle the version number which contains prereleases or similiar. Tests have been added to check that this works.