Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation for TFBuildPullRequestInfo.Id and TFBuildPullRequestInfo.Number #2652

Closed
pascalberger opened this issue Oct 30, 2019 · 0 comments · Fixed by #2653
Closed

Improve documentation for TFBuildPullRequestInfo.Id and TFBuildPullRequestInfo.Number #2652

pascalberger opened this issue Oct 30, 2019 · 0 comments · Fixed by #2653
Assignees
@pascalberger
Labels
Documentation
Milestone
v0.36.0

Comments

@pascalberger
Copy link
Member

pascalberger commented Oct 30, 2019 •
edited
Loading

What You Are Seeing?

Summary for TFBuildPullRequestInfo.Number which is only set while building GitHub repo could be improved.

What is Expected?

Improve documentation to mention that this is only set while building a GitHub repo.

What version of Cake are you using?

0.35.0

Are you running on a 32 or 64 bit system?

N/A

What environment are you running on? Windows? Linux? Mac?

N/A

Are you running on a CI Server? If so, which one?

N/A

How Did You Get This To Happen? (Steps to Reproduce)

Check documentation of TFBuildPullRequestInfo.Number

Output Log

N/A
@pascalberger pascalberger self-assigned this Oct 30, 2019
pascalberger added a commit to pascalberger/cake that referenced this issue Oct 30, 2019
@pascalberger
(cake-buildGH-2652) Fix typo in summary of TFBuildPullRequestInfo.Number
3f96aa5
@pascalberger pascalberger mentioned this issue Oct 30, 2019
Merged
@gep13 gep13 added this to the v0.36.0 milestone Oct 30, 2019
pascalberger added a commit to pascalberger/cake that referenced this issue Oct 30, 2019
@pascalberger
(cake-buildGH-2652) Improve documentation for TFBuildPullRequestInfo.…
7c4feb5 
…Id and TFBuildPullRequestInfo.Number
@pascalberger pascalberger changed the title Typo in TFBuildPullRequestInfo.Number Improve documentation for TFBuildPullRequestInfo.Id and TFBuildPullRequestInfo.Number Oct 30, 2019
gep13 added a commit that referenced this issue Oct 30, 2019
@gep13
Merge pull request #2653 from pascalberger/feature/typo-fix
fa8c53c 
(GH-2652) Improve documentation for TFBuildPullRequestInfo.Id and TFBuildPullRequestInfo.Number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pascalberger pascalberger

Labels
Documentation
Projects
None yet
Milestone
v0.36.0
2 participants
@gep13 @pascalberger