Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary parameter from AddMetadataAttribute method #2640

Closed
gep13 opened this issue Oct 16, 2019 · 0 comments · Fixed by #2641
Closed

Remove unnecessary parameter from AddMetadataAttribute method #2640

gep13 opened this issue Oct 16, 2019 · 0 comments · Fixed by #2641
Assignees
@gep13
Labels
Bug
Milestone
v0.36.0

Comments

@gep13
Copy link
Member

gep13 commented Oct 16, 2019

As discussed here:

#2639 (comment)

The name parameter in the AddMetadataAttribute method is not being used. Since this is a private method, it is safe to remove this parameter, as there will be no external callers.
@gep13 gep13 added the Bug label Oct 16, 2019
@gep13 gep13 added this to the v0.36.0 milestone Oct 16, 2019
@gep13 gep13 self-assigned this Oct 16, 2019
gep13 added a commit to gep13/cake that referenced this issue Oct 16, 2019
@gep13
(cake-buildGH-2640) Remove unnecessary parameter
13b13e6 
This is a private method, so there should be no outside callers,
therefore this is not a breaking change.
@gep13 gep13 mentioned this issue Oct 16, 2019
Merged
devlead added a commit that referenced this issue Oct 16, 2019
@devlead
Merge branch 'gep13-feature/GH-2640' into develop
cdbf303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Bug
Projects
None yet
Milestone
v0.36.0
Development

Successfully merging a pull request may close this issue.

GH2640: Remove unnecessary parameter gep13/cake
1 participant
@gep13