Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chocolatey Package #1840

Closed
gep13 opened this issue Sep 26, 2017 · 7 comments
Closed

Fix Chocolatey Package #1840

gep13 opened this issue Sep 26, 2017 · 7 comments
Assignees
Milestone

Comments

@gep13
Copy link
Member

gep13 commented Sep 26, 2017

Since we are embedding assemblies into the Chocolatey Package, and the Package Validator rules have been increased, we need to include a verification.txt into the package.

@gep13 gep13 added this to the v0.23.0 milestone Sep 26, 2017
@gep13 gep13 self-assigned this Sep 26, 2017
@devlead
Copy link
Member

devlead commented Sep 26, 2017

So basically just add a file like below?

VERIFICATION
Verification is intended to assist the Chocolatey moderators and community
in verifying that this package's contents are trustworthy.

This package is published by the Cake Project itself. The binaries are 
identical to other package types published by the project, in particular
the Cake.Portable nuget package.

@gep13
Copy link
Member Author

gep13 commented Sep 26, 2017

Yip, that pretty much covers it.

More information here:

https://github.com/chocolatey/package-validator/wiki/VerificationFileMissing

@devlead
Copy link
Member

devlead commented Sep 26, 2017

yeah read that, not über clear what the file should contain reading that wiki though :)

@devlead
Copy link
Member

devlead commented Sep 26, 2017

See that
Providing checksums in verification is helpful, but OPTIONAL

So above and we should be good to go.

@gep13
Copy link
Member Author

gep13 commented Sep 26, 2017

Any suggestions on how the wiki can be improved would be welcome :-)

@waynebrantley
Copy link

What does it take to get this approved?
https://chocolatey.org/packages/cake.portable/0.22.2

The problem is the addins - like cake-contrib/Cake.FileHelpers#17 are requiring the 0.22 version.

Chicken and egg!

@gep13
Copy link
Member Author

gep13 commented Oct 2, 2017

@waynebrantley the fix is as described above. We need to add the verification.txt file to the package and re-push to chocolatey.org.

In the interim, so can install that version of the chocoatey package by specifying the version number in the command line. Or you can pin to earlier versions of both cake, and cake.filehelpers.

gep13 added a commit to gep13/cake that referenced this issue Oct 9, 2017
- This leaves scope for adding of other .txt files that may/or may not be required in future versions of Chocolatey
devlead added a commit that referenced this issue Oct 9, 2017
* gep13-feature/GH-1840:
  (GH-1840) Added Verification.txt to Chocolatey Package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants