(GH-129) When using .NET Global tool, resolve Cake.dll to netcoreapp3.1 #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: (build) Add dotnet cli environment variables
* hotfix/0.6.1: (cake-buildGH-127) Fixed wrong path in cake-tool detection
…etcoreapp3.1 Bakery currently needs Cake.Core and Cake.Common targeting netstandard2.0 only cake-build#129 (comment)
bjorkstromm
approved these changes
Mar 8, 2021
|
I have tested it and it does work - but only for Cake 1.1.0. (Neiter Cake 1.0.0, nor Cake 0.38.5 will work - since none of them ship Would it be possible to change the glob from |
augustoproiete
force-pushed
the
force-netcoreapp3-1-for-dotnet-global-tool
branch
from
b5d09df to
9cf5942
Compare
|
@bjorkstromm Yes, tested with 1.1.0. @nils-a Good catch. I updated the PR earlier this morning to resolve Cake Tool 1.1.0 resolves to:
|
bjorkstromm
approved these changes
Mar 8, 2021
|
@augustoproiete I have rebased and merged this into a hotfix branch here: c1e22a1 As a result, going to close out this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bakery currently needs
Cake.CoreandCake.Commontargetingnetstandard2.0only as per @bjorkstromm's comment #129 (comment)