Simplify test var execution, cleanups #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robhanlon22
force-pushed
the
use-greenlight-printing
branch
from
d22e60d to
238d4e3
Compare
* Remove implementations of clojure.test/report in lieu of just following greenlight's execution path and using greenlight.report/handle-test-event. This removes a lot of code. * Just use kaocha's implementation of kaocha.testable/-run to run greenlight test vars. This just requires a small function wrapper to make this work as expected. Also removes a lot of code. * Rename :caioaao.kaocha-greenlight.test/test-var to :caoioaao.kaocha-greenlight.test.var/var to match kaocha's internal keyword naming. * Namespace cleanups. * Bump greenlight dependency to latest. * Fix up expound printer setup.
robhanlon22
force-pushed
the
use-greenlight-printing
branch
from
238d4e3 to
ffa1e19
Compare
dparis
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following greenlight's execution path and using
greenlight.report/handle-test-event. This removes a lot of code.
greenlight test vars. This just requires a small function wrapper to
make this work as expected. Also removes a lot of code.
:caoioaao.kaocha-greenlight.test.var/var to match kaocha's internal
keyword naming.