Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

probe validation and recovery improvements #13

Merged
merged 2 commits into from
Oct 24, 2022
Merged

probe validation and recovery improvements #13

merged 2 commits into from
Oct 24, 2022

Conversation

caio
Copy link
Owner

@caio caio commented Oct 24, 2022 •
edited
Loading

this:

  • ensures the probe state is clean if the instance goes idle in the middle of a probe cycle
  • makes foca go back to a fully functional state in case it detects another case of incomplete probe cycle

resolves #2

caio added 2 commits October 24, 2022 11:03
@caio
bug: ensure a valid probe state when going idle
c654592 
another missing cleanup. I suspect this is the last as we only
have two inactive states and the previous missing one [^1] covered
the defunct case

[^1]: 907b363
@caio
gracefully recover from IncompleteProbeCycle
4dce057
@caio caio mentioned this pull request Oct 24, 2022
Closed
@caio caio merged commit 9de06f5 into main Oct 24, 2022
@caio caio deleted the probe-state branch October 24, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encountered: "BUG! Probe cycle finished without running its full course"
1 participant
@caio