Merge pull request #442 from cailloumajor/remove-compute-api-target-c…

…ycle-time-param feat: remove target cycle time API query param
cailloumajor · Sep 7, 2023 · f5a06e8 · f5a06e8
2 parents ae2dc73 + 87328ed
commit f5a06e8
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 29 deletions.
diff --git a/src/components/TimelineDisplay.vue b/src/components/TimelineDisplay.vue
@@ -41,7 +41,6 @@ import { QCard } from "quasar"
 import { computed, nextTick, onMounted, reactive, ref } from "vue"
 
 import { isMandeError, timelineRefreshMillis } from "src/global"
-import { useCampaignDataStore } from "src/stores/campaign-data"
 
 import wasmUtils from "./frontend-utils-wasm"
 
@@ -64,8 +63,6 @@ const props = defineProps<{
   legend: LegendItem[]
 }>()
 
-const campaignDataStore = useCampaignDataStore()
-
 const cardElem = ref<InstanceType<typeof QCard> | null>(null)
 const canvasElem = ref<HTMLCanvasElement | null>(null)
 
@@ -113,9 +110,6 @@ onMounted(() => {
   const drawTimeline = () => {
     mande(props.computeApiUrl)
       .get({
-        query: {
-          targetCycleTime: campaignDataStore.targetCycleTime,
-        },
         responseAs: "response",
       })
       .then((response) => {

diff --git a/src/components/__tests__/TimelineDisplay.cy.ts b/src/components/__tests__/TimelineDisplay.cy.ts
@@ -1,6 +1,5 @@
 import TimelineDisplayWrapper from "app/test/cypress/wrappers/TimelineDisplayWrapper.vue"
 import { timelineRefreshMillis } from "src/global"
-import { useCampaignDataStore } from "src/stores/campaign-data"
 
 import useWasmUtils from "../frontend-utils-wasm"
 
@@ -113,13 +112,6 @@ describe("TimelineDisplay", () => {
 
     mountComponent()
 
-    cy.wrap(useCampaignDataStore()).invoke("$patch", {
-      targetCycleTime: 84.653,
-    })
-
-    cy.wait("@timeline-request")
-      .its("request.query")
-      .should("include", { targetCycleTime: "84.653" })
     cy.get<SinonStub>("@draw-stub").should("have.been.calledWith", body)
   })
 

diff --git a/src/pages/LineDashboard.vue b/src/pages/LineDashboard.vue
@@ -318,7 +318,6 @@ const updatePerformance = () => {
     .get<number>(props.id, {
       query: {
         clientTime: dayjs().format(),
-        targetCycleTime: campaignDataStore.targetCycleTime,
       },
     })
     .then((value) => {

diff --git a/src/pages/__tests__/LineDashboard.cy.ts b/src/pages/__tests__/LineDashboard.cy.ts
@@ -447,20 +447,6 @@ describe("LineDashboard", () => {
         .should("include", { clientTime: "1984-12-09T04:32:01+03:00" })
     })
 
-    it("passes target cycle time to compute API", () => {
-      mountComponent()
-
-      cy.wrap(useCampaignDataStore()).invoke("$patch", {
-        targetCycleTime: 64.46,
-      })
-
-      cy.tick(1100)
-
-      cy.wait("@performance-request")
-        .its("request.query")
-        .should("include", { targetCycleTime: "64.46" })
-    })
-
     it("sets the metric text", () => {
       mountComponent()