Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🥅 Handle error details on inactive rpc errors #384

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

evaline-ju
Copy link
Collaborator

@evaline-ju evaline-ju commented Aug 16, 2024

Previously #372 was added to give connection errors a more understandable user message, but this obscured some unary generation validation errors

In this PR:

  • Serializing err.details was leading to JSON errors - this should be err.details()
  • Non-connection errors such as validation errors [invalid argument] were getting surfaced with the inactive RPC connection message incorrectly

Test command with this fix

grpcurl -plaintext -H "mm-model-id: [model-id]" -d '{
  "stopSequences": [],
  "text": "sad",
  "tokenLogprobs": true
}' localhost:8085 caikit.runtime.Nlp.NlpService.TextGenerationTaskPredict

Signed-off-by: Evaline Ju <[email protected]>
@evaline-ju evaline-ju marked this pull request as ready for review August 19, 2024 19:15
@evaline-ju evaline-ju linked an issue Aug 19, 2024 that may be closed by this pull request
Copy link
Collaborator

@gkumbhat gkumbhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 thanks for fixing it. LGTM.

@gkumbhat gkumbhat merged commit a55b72e into caikit:main Aug 19, 2024
5 checks passed
@gkumbhat gkumbhat deleted the err-details branch August 19, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TGIS unary generation validation error not being propagated
2 participants