Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #4

Merged
merged 3 commits into from
Aug 12, 2019
Merged

Improvements #4

merged 3 commits into from
Aug 12, 2019

Conversation

cd1989
Copy link

@cd1989 cd1989 commented Aug 11, 2019

  • Make regular updater configurable
  • Rewrite Dockerfile to use dumb-init

@caicloud-bot
Copy link

@cd1989: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@caicloud-bot caicloud-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. labels Aug 11, 2019
@cd1989
Copy link
Author

cd1989 commented Aug 11, 2019

/release-note-none

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 11, 2019
@cd1989 cd1989 requested a review from supereagle August 11, 2019 05:00
@supereagle
Copy link
Member

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2019
@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: supereagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2019
@caicloud-bot caicloud-bot merged commit 74568a8 into caicloud:release-2.0.8 Aug 12, 2019
@zhujian7
Copy link

@supereagle Do you remember why we need dump-init in the PR?

@supereagle
Copy link
Member

@supereagle Do you remember why we need dump-init in the PR?

To fix zombie process. Xref: quay#477

caicloud-bot pushed a commit that referenced this pull request May 15, 2020
@hyy0322 @cd1989
update api to release-2.1 (#6)
9860bab 
* Update apis 2.0.8 (#3)

* feat: support update vulnerabilities database by cron and API

* chore: add robfig/cron to vendor

* fix: remove unused imports

* Add api to get updater schedule

* Improvements (#4)

* feat: make updater configurable

* feat: rewrite Dockerfile to use dumb-init

* fix: stop schedule when update settings

* fix: complete test

Co-authored-by: De Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supereagle supereagle Awaiting requested review from supereagle

Assignees

@supereagle supereagle

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cd1989 @caicloud-bot @supereagle @zhujian7