Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for installed scipy version #20

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

ohearnk
Copy link
Contributor

@ohearnk ohearnk commented Apr 9, 2024

scipy.linag.tril is missing for scipy > v1.12.0 (see, e.g., octo-models/octo#71).

This PR pins the installed version to at most v1.12.0. This change can be removed in the future if the dependent code instead switches to using numpy.tril for newer versions of numpy (https://numpy.org/doc/stable/reference/generated/numpy.tril.html).

@cagrikymk
Copy link
Owner

Hi Kurt,
Yes this seems appropriate, thank you for the fix!

@cagrikymk cagrikymk merged commit 3d8bfc6 into cagrikymk:master Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants