Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redacting "code=" from notify post #95

Merged
merged 6 commits into from
Nov 8, 2021
Merged

Redacting "code=" from notify post #95

merged 6 commits into from
Nov 8, 2021

Conversation

carterm
Copy link
Contributor

@carterm carterm commented Nov 1, 2021

This will replace the function key in the notify output with the first 3 chars and a [...].

@carterm
Copy link
Contributor Author

carterm commented Nov 1, 2021

#90

@carterm carterm linked an issue Nov 1, 2021 that may be closed by this pull request
Reduce "Full Details" view in notifications #90
Closed
@carterm carterm requested a review from a team November 5, 2021 21:31
chachasikes
chachasikes approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@chachasikes chachasikes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but wondering why did you redact it?

@carterm
Copy link
Contributor Author

carterm commented Nov 8, 2021

Approving, but wondering why did you redact it?

Because that's the secret key. Shouldn't be fully displayed in logs.

@carterm carterm merged commit 79f73bb into main Nov 8, 2021
@carterm carterm deleted the Cleaning-up-notification-post branch November 8, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chachasikes chachasikes chachasikes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce "Full Details" view in notifications
2 participants
@carterm @chachasikes