Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#83 Clarify instructions. #82

Merged
merged 6 commits into from
Nov 5, 2021
Merged

#83 Clarify instructions. #82

merged 6 commits into from
Nov 5, 2021

Conversation

zakiya
Copy link
Contributor

@zakiya zakiya commented Oct 26, 2021

No description provided.

@zakiya zakiya marked this pull request as draft October 26, 2021 18:43
@zakiya zakiya changed the title Clarify instructions for wordpress-to-github.config.json. #83 Clarify instructions. Oct 26, 2021
@zakiya zakiya marked this pull request as ready for review October 26, 2021 23:42
@zakiya zakiya requested a review from carterm October 26, 2021 23:42
README.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -32,7 +32,7 @@ There are a few configuration files that need to be used.

### wordpress-to-github.config.json

Controls how the service will place content in GitHub.
Controls how the service will place content in GitHub. Copy `wordpress-to-github/schemas/wordpress-to-github-sample.config.json` from this repo to your target repo (e.g. `drought-ca-gov`) as `wordpress/config/wordpress-to-github.config.json`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we telling them to copy? There needs to be a purpose if this is instructions. This is a description of the file.

@chachasikes chachasikes self-requested a review November 2, 2021 15:16
@zakiya zakiya requested a review from carterm November 4, 2021 16:32
@carterm carterm linked an issue Nov 5, 2021 that may be closed by this pull request
@zakiya zakiya merged commit 23ac7d6 into main Nov 5, 2021
@carterm carterm deleted the testing-feedback branch November 8, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and update README
3 participants