Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform the "Development/Production" site into a Development site. #76

Merged
merged 10 commits into from
Oct 29, 2021

Conversation

carterm
Copy link
Contributor

@carterm carterm commented Oct 25, 2021

Using project ref to create a dev environment for the module. Should be able to publish to NPM when ready.

This release should hold until all the major endpoints are distributed, but further dev work should branch off this.

This transforms the "production" site into a development site.

@carterm carterm requested review from a team October 26, 2021 17:46
Copy link
Contributor

@chachasikes chachasikes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change could break production, right (any pushes you do to main are immediately deployed and will effect all instances?

  • Is it possible to do this major change work in a development branch & endpoint so we can really review it as a team? (And leave production instance alone until we push the next version & can plan to have all hands on deck?)

Leaving review open for others to also comment.

@carterm
Copy link
Contributor Author

carterm commented Oct 26, 2021

Added "This release should hold until all the major endpoints are distributed, but further dev work should branch off this."

@carterm carterm changed the title New module separation Transform the "Production" site into a Development site. Oct 26, 2021
@carterm carterm changed the title Transform the "Production" site into a Development site. Transform the "Development/Production" site into a Development site. Oct 26, 2021
@zakiya
Copy link
Contributor

zakiya commented Oct 26, 2021

I understand the code (I think) but am confused by your use of the word "site" here and possibly "module". Also does "this release should hold" mean "merging this PR shouldn't break anything"?

It looks like functionally this change turns this repo into a package the references in the code are now package references instead of paths to code. I'm also hesitant to approve without a test or code review by someone who knows this service better. Maybe a morning huddle?

@carterm
Copy link
Contributor Author

carterm commented Oct 27, 2021

I understand the code (I think) but am confused by your use of the word "site" here and possibly "module". Also does "this release should hold" mean "merging this PR shouldn't break anything"?

It looks like functionally this change turns this repo into a package the references in the code are now package references instead of paths to code. I'm also hesitant to approve without a test or code review by someone who knows this service better. Maybe a morning huddle?

Hold, meaning let's not deploy until all the "production" site references are moved to new locations. When all the "production" site references are moved, this will just be the development service that is connected to the development source for the module.

@carterm
Copy link
Contributor Author

carterm commented Oct 28, 2021

@carterm carterm merged commit 4b58d3c into main Oct 29, 2021
@carterm carterm deleted the new-module-separation branch October 29, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants