-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform the "Development/Production" site into a Development site. #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change could break production, right (any pushes you do to main
are immediately deployed and will effect all instances?
- Is it possible to do this major change work in a development branch & endpoint so we can really review it as a team? (And leave production instance alone until we push the next version & can plan to have all hands on deck?)
Leaving review open for others to also comment.
Added "This release should hold until all the major endpoints are distributed, but further dev work should branch off this." |
I understand the code (I think) but am confused by your use of the word "site" here and possibly "module". Also does "this release should hold" mean "merging this PR shouldn't break anything"? It looks like functionally this change turns this repo into a package the references in the code are now package references instead of paths to code. I'm also hesitant to approve without a test or code review by someone who knows this service better. Maybe a morning huddle? |
Hold, meaning let's not deploy until all the "production" site references are moved to new locations. When all the "production" site references are moved, this will just be the development service that is connected to the development source for the module. |
Merge this pr...https://github.com/cagov/wordpress-to-github/pull/88...to be done. |
Using project ref to create a dev environment for the module. Should be able to publish to NPM when ready.
This release should hold until all the major endpoints are distributed, but further dev work should branch off this.
This transforms the "production" site into a development site.