Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speeding up binary downloads #115

Merged
merged 1 commit into from
Dec 1, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions wordpress-to-github/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -328,28 +328,37 @@ const SyncEndpoint = async (
if (mediaChanges.length) {
console.log(`Checking ${mediaTree.length} media items`);

/** @type {Promise<void>[]} */
const binarySyncs = [];

//Pull in binaries for any media meta changes
for (const mediaTreeItem of mediaChanges) {
if (mediaTreeItem.sizes) {
//Sized images
for (const sizeJson of mediaTreeItem.sizes) {
await syncBinaryFile(
sizeJson.wordpress_url,
gitRepo,
mediaTree,
endpointConfig
binarySyncs.push(
syncBinaryFile(
sizeJson.wordpress_url,
gitRepo,
mediaTree,
endpointConfig
)
);
}
}

//not sized media (PDF or non-image)
await syncBinaryFile(
mediaTreeItem.wordpress_url,
gitRepo,
mediaTree,
endpointConfig
binarySyncs.push(
syncBinaryFile(
mediaTreeItem.wordpress_url,
gitRepo,
mediaTree,
endpointConfig
)
);
}

await Promise.all(binarySyncs);
}

//Remove any leftover binary placeholders...
Expand Down