Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing clean-out option for general file #102

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Removing clean-out option for general file #102

merged 1 commit into from
Nov 8, 2021

Conversation

carterm
Copy link
Contributor

@carterm carterm commented Nov 2, 2021 •
edited
Loading

Solves #96

@carterm carterm linked an issue Nov 2, 2021 that may be closed by this pull request
general.json writing will clear other files in folder. #96
Closed
@carterm carterm requested a review from a team November 5, 2021 21:30
chachasikes
chachasikes approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@chachasikes chachasikes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: will this prevent general file OR FOLDER PATH from being removed?

@carterm
Copy link
Contributor Author

carterm commented Nov 8, 2021

Q: will this prevent general file OR FOLDER PATH from being removed?

Yes. Inspired by your folder destruction discovery.

@carterm carterm merged commit 5f3469f into main Nov 8, 2021
@carterm carterm deleted the Removing-cleanout-option-for-general-file branch November 8, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chachasikes chachasikes chachasikes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

general.json writing will clear other files in folder.
2 participants
@carterm @chachasikes