Update styles with R2 test findings #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorder based on recommended order in https://github.com/Office-of-Digital-Innovation/California-State-Template/blob/master/ssi/head-css-js.html
rocketnova
commented
Nov 24, 2021
Comment on lines
+2
to
+4
| @import './cagov.core.css'; | ||
| @import './colorscheme-oceanside.css'; | ||
| @import './custom.css'; |
There was a problem hiding this comment.
Note: these are the substantive changes to this file. Other changes are auto-lint changes.
1 task
rocketnova
changed the title
lomky
reviewed
Nov 29, 2021
| @@ -2,7 +2,7 @@ | |||
| * Preview.js is loaded in the Canvas tab, the “preview” iframe that renders your components in isolation. Use preview.js | |||
| * for global code (such as CSS imports or JavaScript mocks) that applies to all stories. | |||
| */ | |||
| import '../styles/globals.scss' | |||
| import '../public/styles/globals.scss' | |||
There was a problem hiding this comment.
@rocketnova I added this in a new commit, but I think its trivial enough that I'm approving & merging
lomky
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #560
Changes
cagov.font-only.csswithcagov.core.cssin order to pull in default stylescustom.cssthat includes their brand overrides of the base cagov brand stylescolorscheme-oceanside.min.csswith non minified verion for easier debugging (next will minify anyway)styles/underpublicfancybox/imagesContext
Please ignore changes to
claim-status.json. Merge this PR after #559.Although the desired effect is to update the on-page link styles, pulling in the upstream base css files makes CST more consistent with UIO for minimal effort.
Testing
Visual comparison needed. May want to tag in @nicoleslaw