Add a comment to avoid throwing errors from within logger.log() #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lomky
approved these changes
Nov 4, 2021
rocketnova
added a commit
that referenced
this pull request
Nov 9, 2021
29a66b5 Update application insights to 2.1.8 (#537) 1a14c3f Add a comment to avoid throwing errors from within logger.log (#536) 48390ea Add an environment variable for more flexibility for static asset path (#525) 8e9b3c6 Update to latest chromatic (#533) 17c5766 Update ansi-regex (#535) f803ae6 Log a UUID for all traces in a single request/response cycle using a pino child logger (#523) 97c30f3 Adds an error catch for null responses 62bfe42 Fine tunes & then hides the Global Header on main f871c44 Run CI on future and PRs against future & production a40fbf1 Flexible context root c89a69c Creates the Global Header d79ff60 Bump semver-regex from 3.1.2 to 3.1.3 (#499) 6e5dfae Bump nth-check from 2.0.0 to 2.0.1 (#498) 5183e49 Bump prismjs from 1.24.1 to 1.25.0 (#497) 273f813 Bump tmpl from 1.0.4 to 1.0.5 (#496) 3bd7615 Security update: set-value (#495) f48d2cf Adds storybooks for Maintenance Component & Page under Maintenance d30ff5e Update dependencies (#488) 2be865a Missing Application Insights environment variable should not disrupt claimant experience (#469) 5ea5fe3 Update modheader instructions in readme 0f32698 Remove default argument values in InfoField (#463)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Changes
Context
In #471, we identified that uncaught errors will cause the application to display an unrendered and untranslated 500 error page. After researching this issue, I came to the conclusion that there isn't an easy technical solution. We have already put all of our function calls inside
try/catchblocks.It is possible to generate an uncaught error if you
throw new Error()inside oflogger.log(). That's what caused the issue in #471. However, we have already removed that throw. This PR adds a comment tologger.log()to warn future developers away from accidentally re-introducing this issue.