updated dbt core, snowflake, and bigquery versions

[britt-allen]

Fixes #101

[britt-allen]

IRL sigh, getting a failure: https://github.com/cagov/data-infrastructure/actions/runs/5137261032

[ian-r-rose]

If you add your branch name to the list here you can temporarily build the docs in CI to see if there are any problems:

data-infrastructure/.github/workflows/docs.yml

Line 5 in 46fb01c

- main

I had run into a problem where the built docs were landing in a different place so the logic around copying them into our github pages deploy broke. Totally fixable, but annoying. But it's possible that was an unintentional regression that has since been fixed.

[ian-r-rose]

@britt-allen are you able to check/fix the docs build?

[britt-allen]

Docs build complete and ready for merging @ian-r-rose

[ian-r-rose]

Looks like the docs build had some problems, cf: https://cagov.github.io/dbt_docs_snowflake/index.html

[ian-r-rose]

This is a breaking change to where dbt places the built project in 1.5 notice where it places the docs directory when running 1.4:

https://github.com/cagov/data-infrastructure/actions/runs/5136928618/jobs/9244319759#step:9:66

vs where it places the docs directory when running 1.5:

https://github.com/cagov/data-infrastructure/actions/runs/5149087990/jobs/9271648644#step:9:64

That is what I was referring to in #101. I think it would fix things to just change the cp statement.

[ian-r-rose]

Found an issue for it: dbt-labs/dbt-core#7465

Looks like it was an unintentional change and will be fixed in the next release of dbt (1.5.2). So it might fix itself if we just wait and then bump the version again.

[britt-allen]

So the current docs checks are not capable of catching this issue, correct? And that's why the checks passed despite the build actually being broken? @ian-r-rose

[britt-allen]

Should we write a test that doesn't let the check pass if the url is erroring out? I am also having a bit of trouble finding the cp statement you mentioned. May Slack you on Monday after a bit more digging. @ian-r-rose

[ian-r-rose]

So the current docs checks are not capable of catching this issue, correct? And that's why the checks passed despite the build actually being broken? @ian-r-rose

Correct, there aren't really any docs checks right now, it's a very manual process

[ian-r-rose]

The relevant lines are here:

data-infrastructure/.github/workflows/docs.yml

Lines 47 to 54 in 46fb01c

	# Generate snowflake dbt docs
	dbt deps --project-dir=transform
	dbt docs generate --project-dir=transform
	cp -r transform/target docs/dbt_docs_snowflake
	# Generate bigquery dbt docs
	dbt deps --project-dir=transform-bigquery
	dbt docs generate --project-dir=transform-bigquery
	cp -r transform-bigquery/target docs/dbt_docs_bigquery

But it does look like if we wait a week or two this will be fixed with the next dbt release.

[ian-r-rose]

Sigh, two steps forward, one step back. This is now blocked by dbt-labs/dbt-core#7937

[britt-allen]

Hey Ian, can I get a tl;dr on why u removed some of the packages you did?

[ian-r-rose]

These are managed by poetry, so I'm not sure. It's a consequence of updating the versions above: somewhere in their dependency tree something required those packages before, and no longer does.

[britt-allen]

Can't approve my own PR, but looks good.

[britt-allen]

@AeriShan-ODI Ian and I both worked on this so would you mind reviewing and approving or soliciting more work if needed. it's my PR so I cannot approve. Thanks!

[ian-r-rose]

Just testing the docs build on this branch, then I'll revert and if things work well, should be good to go.

Edit: things seem to be working fine, this should be ready

[AeriShan-ODI]

Tested, no issues found