Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates to ReadMe to include Azure DevOps and dbt Cloud #46

Merged
merged 3 commits into from
Nov 5, 2024
Merged

updates to ReadMe to include Azure DevOps and dbt Cloud #46

merged 3 commits into from
Nov 5, 2024

Conversation

britt-allen
Copy link
Contributor

@britt-allen britt-allen commented Oct 30, 2024 •
edited
Loading

closes #45

@britt-allen britt-allen self-assigned this Oct 30, 2024
ian-r-rose
ian-r-rose reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@ian-r-rose ian-r-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

README.md Outdated Show resolved Hide resolved
{{project_name}}/transform/models/sample_data.sql.jinja Outdated
@@ -1,3 +1,4 @@
{% if execute %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this if block needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was experimenting to try to solve this error. the error message points me to a dbt article that makes use of such a block

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may actually be due to some of the work @ram-kishore-odi is doing in cagov/data-infrastructure#413. Our dev roles are currently a bit messed up, and that can break CI here.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @britt-allen, Ian is right. terraform snowflake provider upgrade to v 0.97 is in progress and I am trying to wrap it up asap. But we are facing some unexpected situations which is causing the delays to upgrade dev.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that error can be ignored for now then? @ian-r-rose @ram-kishore-odi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think so.

ian-r-rose
ian-r-rose approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@ian-r-rose ian-r-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's wait till end-of-day to see if we can get CI resolved, if not I'll merge

@ian-r-rose
Copy link
Member

Thanks @britt-allen

@ian-r-rose ian-r-rose merged commit 00cc179 into main Nov 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-r-rose ian-r-rose ian-r-rose approved these changes

@ram-kishore-odi ram-kishore-odi Awaiting requested review from ram-kishore-odi

Assignees

@britt-allen britt-allen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add devops repo set up to infra template instructions
3 participants
@britt-allen @ian-r-rose @ram-kishore-odi