fix-dead-object-exception #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHELAT
suggested changes
Dec 10, 2020
Comment on lines
+88
to
+90
| } catch (ignored: DeadObjectException) { | ||
| // onServiceDisconnected will get called so no need to do anything | ||
| } |
There was a problem hiding this comment.
We shouldn't suppress this exception. Developer should know that their app has disconnected from the IAB service. So, I'd suggest to do this instead:
callback?.connectionFailed?.invoke(e)
PHELAT
pushed a commit
that referenced
this pull request
Dec 28, 2020
* Do not pass IInAppBillingService as a parameter * Catch DeadObjectException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dead object exception when bazaar process get killed for any reason.