Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add epd7in5b_v2 support #118

Merged
merged 4 commits into from
Oct 21, 2022
Merged

Add epd7in5b_v2 support #118

merged 4 commits into from
Oct 21, 2022

Conversation

peckpeck
Copy link
Contributor

Support of 7.5" (b) v2 (3 colors with back, white, red)
It is based on epd7in5_v2 which doesn't work (epd7in5_v3 neither)
It is also based on the arduino C driver and datasheet.
It works on my V3 but the C driver and the datasheet haven't changed between v2 and v3.

@auto-assign auto-assign bot requested a review from caemor October 14, 2022 10:59
@@ -0,0 +1,156 @@
//! SPI Commands for the Waveshare 7.5"(B) V2 E-Ink Display
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//! SPI Commands for the Waveshare 7.5"(B) V2 E-Ink Display
//! SPI Commands for the Waveshare 7.5"(B) V2 and V3 E-Ink Display

Maybe include the v3 as well then if its already tested and working with the same commands.

Copy link
Owner

@caemor caemor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the display(s) to the changelog and the readme as well?

@caemor caemor assigned peckpeck and unassigned caemor Oct 20, 2022
@peckpeck
Copy link
Contributor Author

Done

Copy link
Owner

@caemor caemor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@caemor caemor merged commit b909be6 into caemor:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants