Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracting raw type before creating BeanClass #837

Merged
merged 3 commits into from
Oct 14, 2014
Merged

Extracting raw type before creating BeanClass #837

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7026e21
Anproxy class
felipeweb Oct 13, 2014
c0fabe1
Anproxy variable
felipeweb Oct 14, 2014
ee3b83b
remove sepaces to tabs
felipeweb Oct 14, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions vraptor-core/src/main/java/br/com/caelum/vraptor/controller/DefaultControllerMethod.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

package br.com.caelum.vraptor.controller;

import br.com.caelum.vraptor.proxy.CDIProxies;

import java.lang.annotation.Annotation;
import java.lang.reflect.Method;
import java.util.Objects;
Expand All @@ -35,6 +37,7 @@ public DefaultControllerMethod(BeanClass controller, Method method) {
}

public static ControllerMethod instanceFor(Class<?> type, Method method) {
CDIProxies.extractRawTypeIfPossible(type);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use tabs instead of spaces.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't test yet
I will finish it tomorow
Don't merge yet

Em segunda-feira, 13 de outubro de 2014, Otávio Garcia <
[email protected]> escreveu:

In
vraptor-core/src/main/java/br/com/caelum/vraptor/controller/DefaultControllerMethod.java:

@@ -35,6 +37,7 @@ public DefaultControllerMethod(BeanClass controller, Method method) {
}

public static ControllerMethod instanceFor(Class<?> type, Method method) {

  •    CDIProxies.extractRawTypeIfPossible(type);

Use tabs instead of spaces.

—
Reply to this email directly or view it on GitHub
https://github.com/caelum/vraptor4/pull/837/files#r18797113.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to assign the result of the method call, Felipe. You
should do something like:

type = CDIProxies.extractEtcEtc(type);

Chico Sokol

On Mon, Oct 13, 2014 at 7:36 PM, Felipe Oliveira [email protected]
wrote:

In
vraptor-core/src/main/java/br/com/caelum/vraptor/controller/DefaultControllerMethod.java:

@@ -35,6 +37,7 @@ public DefaultControllerMethod(BeanClass controller, Method method) {
}

public static ControllerMethod instanceFor(Class<?> type, Method method) {

  •    CDIProxies.extractRawTypeIfPossible(type);

I don't test yet I will finish it tomorow Don't merge yet Em
segunda-feira, 13 de outubro de 2014, Otávio Garcia <
[email protected]> escreveu:
… <#1490ba774297fa3d_>
In
vraptor-core/src/main/java/br/com/caelum/vraptor/controller/DefaultControllerMethod.java:

@@ -35,6 +37,7 @@ public DefaultControllerMethod(BeanClass controller,
Method method) { > } > > public static ControllerMethod
instanceFor(Class<?> type, Method method) { > +
CDIProxies.extractRawTypeIfPossible(type); Use tabs instead of spaces. —
Reply to this email directly or view it on GitHub <
https://github.com/caelum/vraptor4/pull/837/files#r18797113>.

—
Reply to this email directly or view it on GitHub
https://github.com/caelum/vraptor4/pull/837/files#r18799361.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll finish it with @felipeweb today.
After testing on a real app we'll merge here.

return new DefaultControllerMethod(new DefaultBeanClass(type), method);
}

Expand Down