Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructor eyes only cdi and formatting of injections docs #742

Merged
merged 5 commits into from
Aug 18, 2014

Conversation

vitornp
Copy link
Contributor

@vitornp vitornp commented Aug 14, 2014

  • Standardizing the formatting of injections
  • Converting list of events triggered to table
  • Close class ClienteController in components

/**
* @deprecated CDI eyes only
*/
public ClientsController(){
protected ClientsController(){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think should be public to CDI eyes. Why protected.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope. protected is better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really. Sorry. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need the default constructor, since it isn't private, is it ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error:
WELD-001435: Normal scoped bean class ClientsController is not proxyable because it has no no-args constructor - <unknown javax.enterprise.inject.spi.Bean instance>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using injection in the constructor is needed the default constructor to CDI. Just can't be private.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, get it wrong your question. That's it!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @vitornp. I told just about the private default constructor, just in this case we get error.

Anyway, thanks. 😃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻

@Turini
Copy link
Member

Turini commented Aug 18, 2014

after the minor we will merge it! thanks @vitornp

@vitornp
Copy link
Contributor Author

vitornp commented Aug 18, 2014

@Turini Done!!!

Turini added a commit that referenced this pull request Aug 18, 2014
Constructor eyes only cdi and formatting of injections docs
@Turini Turini merged commit 822ca9d into caelum:master Aug 18, 2014
@Turini
Copy link
Member

Turini commented Aug 18, 2014

thanks!

@vitornp vitornp deleted the docs branch August 18, 2014 16:47
@vitornp
Copy link
Contributor Author

vitornp commented Aug 18, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants