Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builder: Ignore tidy errors #142

Merged
merged 1 commit into from
May 9, 2023
Merged

builder: Ignore tidy errors #142

merged 1 commit into from
May 9, 2023

Conversation

francislavoie
Copy link
Member

See the conversation in the gophers slack: https://gophers.slack.com/archives/C9BMAAFFB/p1683645084906259?thread_ts=1683329744.706999&cid=C9BMAAFFB

Help doc for -e:

The -e flag causes tidy to attempt to proceed despite errors encountered while loading packages.

The effect is that some errors might be reported in stderr, but if non-critical it should ideally be able to push forwards and still complete tidying. If there's any more serious errors, go build should error out.

@francislavoie francislavoie added the enhancement New feature or request label May 9, 2023
@francislavoie francislavoie requested review from mholt and mohammed90 May 9, 2023 15:26
mohammed90
mohammed90 approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@mohammed90 mohammed90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. The Slack conversation makes sense and clarifies some points. Let's try it out.

@francislavoie francislavoie merged commit c9644d6 into master May 9, 2023
@francislavoie francislavoie deleted the ignore-tidy-errors branch May 9, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammed90 mohammed90 mohammed90 approved these changes

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@francislavoie @mholt @mohammed90