Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add XCADDY_GO_MOD_FLAGS env var to allow passing custom go mod flags #113

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

mohammed90
Copy link
Member

This is a follow-up to #110, as mentioned in #110 (review).

CC/ @akeskimo

@mohammed90 mohammed90 merged commit e6eb334 into master Aug 16, 2022
@mohammed90 mohammed90 deleted the mod-flags branch August 16, 2022 21:27
@mholt
Copy link
Member

mholt commented Aug 16, 2022

Thanks for so diligently helping maintain this @mohammed90!

@aabelix
Copy link
Contributor

aabelix commented Aug 17, 2022

I have confirmed that setting both env XCADDY_GO_BUILD_FLAGS="-modcacherw" XCADDY_GO_MOD_FLAGS="-modcacherw" as per Mohammed's suggestion will allow to clean up the build/pkg directories in our build system. Thank you for the snap update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants