Update readme to reflect the deprecation of "go get -u" #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammed90
requested changes
Aug 21, 2022
There was a problem hiding this comment.
Thank you for catching that and sending the PR! It's probably best to side-step having to track any changes by simply linking to the instructions on the xcaddy repo (https://github.com/caddyserver/xcaddy#install), and perhaps have a note asking the users to ensure $(go env GOPATH)/bin is in their path. The referenced paths can be different for different users and environments, so it's best if we do not assume. This way we don't need to instruct the users
What do you think?
|
Finally got around to tidying this one up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See caddyserver/xcaddy#7