Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverseproxy: Add flag to short command to disable redirects #5330

Merged
merged 3 commits into from
Jan 25, 2023

Conversation

u5surf
Copy link
Contributor

@u5surf u5surf commented Jan 24, 2023

Add new flag --disable-redirects for reverseproxy.
#5290 (comment)
Using a command is more convenient in my case.

@francislavoie francislavoie added the feature ⚙️ New feature or request label Jan 24, 2023
@francislavoie francislavoie added this to the v2.6.3 milestone Jan 24, 2023
@u5surf u5surf force-pushed the issue-5290 branch 2 times, most recently from 0b645fd to 9dbeb1a Compare January 24, 2023 21:47
modules/caddyhttp/reverseproxy/command.go Outdated Show resolved Hide resolved
modules/caddyhttp/reverseproxy/command.go Outdated Show resolved Hide resolved
@francislavoie
Copy link
Member

Oh, you might have missed it but I pushed a commit to the branch to fix #5330 (comment) but I think you force pushed which wiped it out.

@u5surf
Copy link
Contributor Author

u5surf commented Jan 25, 2023

@francislavoie

Oh, you might have missed it but I pushed a commit to the branch to fix #5330 (comment) but I think you force pushed which wiped it out.

I’m sorry my fault, I fixed typo.

Copy link
Member

@francislavoie francislavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like how simple and clean this became.

@francislavoie francislavoie changed the title reverseproxy: Add flag of disable redirects reverseproxy: Add flag to short command to disable redirects Jan 25, 2023
@francislavoie francislavoie merged commit e9d95ab into caddyserver:master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ⚙️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The reverse-proxy does not work when --from https://domain:port
3 participants