admin: Stop writing 500 status on invalid requests #4569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mholt
approved these changes
Feb 11, 2022
|
Yup! I've tested it! I've also made the status Bad Request for missing object ID and malformed object path.
|
francislavoie
changed the title
|
Perfect, thank you for checking! Really appreciate the contribution. |
mholt
pushed a commit
that referenced
this pull request
Feb 15, 2022
mholt
pushed a commit
that referenced
this pull request
Mar 8, 2022
* opentelemetry: create a new module * fix imports * fix test * Update modules/caddyhttp/opentelemetry/README.md Co-authored-by: Dave Henderson <[email protected]> * Update modules/caddyhttp/opentelemetry/README.md Co-authored-by: Dave Henderson <[email protected]> * Update modules/caddyhttp/opentelemetry/README.md Co-authored-by: Dave Henderson <[email protected]> * Update modules/caddyhttp/opentelemetry/tracer.go Co-authored-by: Dave Henderson <[email protected]> * rename error ErrUnsupportedTracesProtocol * replace spaces with tabs in the test data * Update modules/caddyhttp/opentelemetry/README.md Co-authored-by: Francis Lavoie <[email protected]> * Update modules/caddyhttp/opentelemetry/README.md Co-authored-by: Francis Lavoie <[email protected]> * replace spaces with tabs in the README.md * use default values for a propagation and exporter protocol * set http attributes with helper * simplify code * Cleanup modules/caddyhttp/opentelemetry/README.md Co-authored-by: Dave Henderson <[email protected]> * Update link in README.md Co-authored-by: Dave Henderson <[email protected]> * Update documentation in README.md Co-authored-by: Dave Henderson <[email protected]> * Update link to naming spec in README.md Co-authored-by: Dave Henderson <[email protected]> * Rename module from opentelemetry to tracing Co-authored-by: Dave Henderson <[email protected]> * Rename span_name to span Co-authored-by: Dave Henderson <[email protected]> * Rename span_name to span Co-authored-by: Dave Henderson <[email protected]> * Simplify otel resource creation Co-authored-by: Dave Henderson <[email protected]> * handle extra attributes Co-authored-by: Dave Henderson <[email protected]> * update go.opentelemetry.io/otel/semconv to 1.7.0 Co-authored-by: Dave Henderson <[email protected]> * update go.opentelemetry.io/otel version * remove environment variable handling * always use tracecontext,baggage as propagators * extract tracer name into variable * rename OpenTelemetry to Tracing * simplify resource creation * update go.mod * rename package from opentelemetry to tracing * cleanup tests * update Caddyfile example in README.md * update README.md * fix test * fix module name in README.md * fix module name in README.md * change names in README.md and tests * order imports * remove redundant tests * Update documentation README.md Co-authored-by: Dave Henderson <[email protected]> * Fix grammar Co-authored-by: Dave Henderson <[email protected]> * Update comments Co-authored-by: Dave Henderson <[email protected]> * Update comments Co-authored-by: Dave Henderson <[email protected]> * update go.sum * update go.sum * Add otelhttp instrumentation, update OpenTelemetry libraries. * Use otelhttp instrumentation for instrumenting HTTP requests. This change uses context.WithValue to inject the next handler into the request context via a "nextCall" carrier struct, and pass it on to a standard Go HTTP handler returned by otelhttp.NewHandler. The underlying handler will extract the next handler from the context, call it and pass the returned error to the carrier struct. * use zap.Error() for the error log * remove README.md * update dependencies * clean up the code * change comment * move serveHTTP method from separate file * add syntax to the UnmarshalCaddyfile comment * go import the file * admin: Write proper status on invalid requests (#4569) (fix #4561) * update dependencies Co-authored-by: Dave Henderson <[email protected]> Co-authored-by: Francis Lavoie <[email protected]> Co-authored-by: Vibhav Pant <[email protected]> Co-authored-by: Alok Naushad <[email protected]> Co-authored-by: Cedric Ziel <[email protected]>
mholt
added a commit
that referenced
this pull request
Jun 2, 2022
* caddytls: Adding ClientCertValidator for custom client cert validations * caddytls: Cleanups for ClientCertValidator changes caddytls: Cleanups for ClientCertValidator changes * Update modules/caddytls/connpolicy.go Co-authored-by: Francis Lavoie <[email protected]> * Update modules/caddytls/connpolicy.go Co-authored-by: Francis Lavoie <[email protected]> * Update modules/caddytls/connpolicy.go Co-authored-by: Francis Lavoie <[email protected]> * Update modules/caddytls/connpolicy.go Co-authored-by: Francis Lavoie <[email protected]> * Update modules/caddytls/connpolicy.go Co-authored-by: Matt Holt <[email protected]> * Update modules/caddytls/connpolicy.go Co-authored-by: Matt Holt <[email protected]> * Unexported field Validators, corrected renaming of LeafVerificationValidator to LeafCertClientAuth * admin: Write proper status on invalid requests (#4569) (fix #4561) * Apply suggestions from code review * Register module; fix compilation * Add log for deprecation notice Co-authored-by: Roettges Florian <[email protected]> Co-authored-by: Francis Lavoie <[email protected]> Co-authored-by: Matt Holt <[email protected]> Co-authored-by: Alok Naushad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4561