Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed pino as a dependency #58

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Conversation

prafed
Copy link
Contributor

@prafed prafed commented Jun 9, 2022

JIRA: https://cabiri.atlassian.net/browse/AS2-149

Updates interfaces and types to be more generic
Tests pass with pino version - "pino": "^6.11.0"

Copy link
Contributor

@kamaz kamaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also please move "@types/pino": "^6.3.5" to dev dependencies?

@kamaz kamaz merged commit a6d43ad into master Jun 10, 2022
@kamaz kamaz deleted the feat/AS2-149-logger-updates branch June 10, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants