fix: eventBridgeMessage handler to pass details object #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamaz
reviewed
Nov 8, 2021
| @@ -5,7 +5,7 @@ import { jsonEventBridgeEvent } from './json-eventbridge-event' | |||
| import { jsonEventBridgeMessage } from './json-eventbridge-message' | |||
|
|
|||
| export type EventBridgeEventHandler = Handler<EventBridgeEvent<string, never>, Context, Promise<void>> | |||
| export type EventBridgeMessageHandler = Handler<EventBridgeEvent<string, string>, Context, Promise<void>> | |||
| export type EventBridgeMessageHandler = Handler<EventBridgeEvent<string, any>, Context, Promise<void>> | |||
There was a problem hiding this comment.
ideally, we would be able to define the payload of EventBridgeEvent and have a specific T around it
that would have to be a different type than Payload as they both can be different
kamaz
approved these changes
Jan 7, 2022
GabZ87
approved these changes
Jan 10, 2022
jeffwad
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
detailobject as payload rather than attempting to parse