fix: sns template, tests and add tests run part of master

.github/workflows/master.yml

@@ -49,6 +49,11 @@ jobs:
 
       - name: build packages
         run: yarn build
+
+      - name: test
+        run: yarn test
+        env:
+          CI: true
 # at the moment it is being release manually
 # - name: publish packages
 #   run: yarn publish:ci

packages/sls-aws/src/cognito/user-pool-handler.ts

@@ -1,15 +1,9 @@
-import { EnvironmentConfig, Handler, SlsEnvironment, SuccessParams, environment } from '@cabiri-io/sls-env'
+import { EnvironmentConfig, Handler, SlsEnvironment, environment } from '@cabiri-io/sls-env'
 import type { Context, PreSignUpTriggerEvent, PreTokenGenerationTriggerEvent } from 'aws-lambda'
+import { responseOrError } from '../reponse/response-or-error'
 
 type PreSignUpHandler = Handler<PreSignUpTriggerEvent, Context, Promise<PreSignUpTriggerEvent>>
 
-const responseOrError = <T>({ result }: SuccessParams<T>): T | never => {
-  if (result) {
-    return result
-  }
-  throw Error("expected event result to be present but it wasn't")
-}
-
 const cognitoUserPoolPreSignUp = <D, C = never>(
   config?: EnvironmentConfig<PreSignUpHandler>
 ): SlsEnvironment<PreSignUpHandler, C, D> => environment<PreSignUpHandler, C, D>(config).successHandler(responseOrError)

packages/sls-aws/src/reponse/response-or-error.ts

@@ -0,0 +1,9 @@
+import { SuccessParams } from '@cabiri-io/sls-env'
+
+const responseOrError = <T>({ result }: SuccessParams<T>): T | never => {
+  if (result) {
+    return result
+  }
+  throw Error("expected event result to be present but it wasn't")
+}
+export { responseOrError }

packages/sls-aws/src/sns/index.ts

@@ -1,15 +1,17 @@
 import { EnvironmentConfig, Handler, SlsEnvironment, environment } from '@cabiri-io/sls-env'
 import type { Context, SNSEvent } from 'aws-lambda'
+import { responseOrError } from '../reponse/response-or-error'
 import { jsonSNSMessage } from './json-sns-message'
 import { jsonSNSMessages } from './json-sns-messages'
 
-type SNSHandler = Handler<SNSEvent, Context, void>
+type SNSHandler = Handler<SNSEvent, Context, Promise<void>>
 
 export const snsMessage = <D, P, C = never>(
   config?: EnvironmentConfig<SNSHandler>
-): SlsEnvironment<SNSHandler, C, D, P> => environment<SNSHandler, C, D, P>(config).payload(jsonSNSMessage)
+): SlsEnvironment<SNSHandler, C, D, P> =>
+  environment<SNSHandler, C, D, P>(config).payload(jsonSNSMessage).successHandler(responseOrError)
 
 export const snsMessages = <D, P, C = never>(
   config?: EnvironmentConfig<SNSHandler>
 ): SlsEnvironment<SNSHandler, C, D, Array<P>> =>
-  environment<SNSHandler, C, D, Array<P>>(config).payload(jsonSNSMessages)
+  environment<SNSHandler, C, D, Array<P>>(config).payload(jsonSNSMessages).successHandler(responseOrError)

packages/sls-env/src/__tests__/application.test.ts

@@ -6,14 +6,14 @@ describe('serverless environment', () => {
     it('uses application to return response', async () =>
       environment<Handler<EmptyEvent, EmptyContext, string>, never, void, void>()
         .app(() => 'hello world!')
-        .successHandler(({ result }) => result)
+        .successHandler(({ result }) => result as string)
         .start({}, {})
         .then(result => expect(result).toBe('hello world!')))
 
     it('uses application to return promise based response', async () =>
       environment<Handler<EmptyEvent, EmptyContext, string>, never, void, void>()
         .app(async () => 'hello world!')
-        .successHandler(({ result }) => result)
+        .successHandler(({ result }) => result as string)
         .start({}, {})
         .then(result => expect(result).toBe('hello world!')))
 

packages/sls-env/src/__tests__/dependencies.test.ts

@@ -17,7 +17,7 @@ describe('serverless environment', () => {
         .app(({ payload: { event, context }, dependencies: { buildMessage } }) =>
           buildMessage(event.message, context.name)
         )
-        .successHandler(({ result }) => result)
+        .successHandler(({ result }) => result as string)
         .start({ message: 'hello' }, { name: 'world' })
         .then(result => expect(result).toBe('hello world!'))
     })
@@ -35,7 +35,7 @@ describe('serverless environment', () => {
         .app(({ payload: { event, context }, dependencies: { buildMessage } }) =>
           buildMessage(event.message, context.name)
         )
-        .successHandler(({ result }) => result)
+        .successHandler(({ result }) => result as string)
         .start({ message: 'hello' }, { name: 'world' })
         .then(result => expect(result).toBe('hello world!'))
     })
@@ -55,7 +55,7 @@ describe('serverless environment', () => {
         .app(({ payload: { event, context }, dependencies: { buildMessage } }) =>
           buildMessage(event.message, context.name)
         )
-        .successHandler(({ result }) => result)
+        .successHandler(({ result }) => result as string)
         .start({ message: 'hello' }, { name: 'world' })
         .then(result => expect(result).toBe('hello world of config!'))
     })

packages/sls-env/src/__tests__/error-handler.test.ts

@@ -7,7 +7,7 @@ describe('serverless environment', () => {
       type AppResult = string
       type HandlerResult = { message: string }
       const result = await environment<Handler<EmptyEvent, EmptyContext, HandlerResult>, void, never, void, AppResult>()
-        .successHandler(({ result }) => ({ message: result }))
+        .successHandler(({ result }) => ({ message: result as string }))
         .app(() => 'app result')
         .start({}, {})
 

packages/sls-env/src/__tests__/index.test.ts

@@ -6,7 +6,7 @@ xdescribe('serverless environment', () => {
     type AppResult = string
     type HandlerResult = { message: string }
     const result = await environment<Handler<EmptyEvent, EmptyContext, HandlerResult>, void, never, void, AppResult>()
-      .successHandler(({ result }) => ({ message: result }))
+      .successHandler(({ result }) => ({ message: result as string }))
       .app(() => 'app result')
       .start({}, {})
 

packages/sls-env/src/__tests__/payload.test.ts

@@ -31,7 +31,7 @@ describe('serverless environment', () => {
           hello: event.message,
           world: context.name
         }))
-        .successHandler(({ result }) => result)
+        .successHandler(({ result }) => result as string)
         .app(({ payload, dependencies: { buildMessage } }) => buildMessage(payload))
         .start({ message: 'hello' }, { name: 'world' })
         .then(result => expect(result).toBe('hello world!'))

packages/sls-env/src/__tests__/success-handler.test.ts

@@ -7,7 +7,7 @@ describe('serverless environment', () => {
       type AppResult = string
       type HandlerResult = { message: string }
       const result = await environment<Handler<EmptyEvent, EmptyContext, HandlerResult>, void, never, void, AppResult>()
-        .successHandler(({ result }) => ({ message: result }))
+        .successHandler(({ result }) => ({ message: result as string }))
         .app(() => 'app result')
         .start({}, {})