Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ntrnl 474 add validation middleware with test page #28

Merged

Conversation

harley-harris
Copy link
Contributor

@harley-harris harley-harris commented Jul 9, 2024

This PR supercedes #25

JIRA link

NTRNL-474

Description

Add validation middleware to node-web-template with a test page

Work checklist

  • Tests added where applicable
  • No vulnerability added
Screenshot 2024-07-09 at 15 30 22

@harley-harris harley-harris self-assigned this Jul 9, 2024
@harley-harris harley-harris requested a review from a team July 9, 2024 14:52
Copy link

github-actions bot commented Jul 9, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 226/226
🟢 Branches
95.24% (+1.12% 🔼)
20/21
🟢 Functions 100% 24/24
🟢 Lines 100% 205/205
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / validation.middleware.ts
100% 100% 100% 100%
🟢
... / validateFilepath.ts
100% 100% 100% 100%
🟢
... / error.messages.ts
100% 100% 100% 100%
🟢
... / validation-test.controller.ts
100% 100% 100% 100%
🟢
... / validation-test.ts
100% 100% 100% 100%
🟢
... / validation-test.validation.ts
100% 100% 100% 100%

Test suite run success

44 tests passing in 22 suites.

Report generated by 🧪jest coverage report action from 5c7c766

@harley-harris harley-harris marked this pull request as ready for review July 9, 2024 14:52
Copy link
Contributor

@Mouhajer-CO Mouhajer-CO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harley-harris approved 👍. Just a minor change. Awesome work with validation path 🔥

@harley-harris harley-harris merged commit 40d63b9 into main Jul 10, 2024
7 checks passed
@harley-harris harley-harris deleted the NTRNL-474-add-validation-middleware-with-test-page branch July 10, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants