Ntrnl 493 add new docker compose configuration #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success29 tests passing in 17 suites. Report generated by 🧪jest coverage report action from fb9ec97 |
Mouhajer-CO
reviewed
Jun 21, 2024
DanielMurray97
deleted the
NTRNL-493-add-new-docker-compose-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
Resolves NTRNL-493
Description
The issue is related to the mounting of the volume in the compose file, we need to mount the volume in order for
nodemonto work correctly in dev mode. However, we can not have this happen in the production side of the application.Action
Add
docker-compose.overridefile with volume mounting config for dev mode.docker-composein root now acts as the base configuration withdocker-compose-overrideextending it conditionally.Add conditional logic to Makefile, which runs dev or prod on
make docker-updepending on the env variableNODE_ENVRemove quotes from
.env.exampleto match MakefileTests added where applicable
No vulnerability added