add jest coverage threshold #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success29 tests passing in 7 suites. Report generated by 🧪jest coverage report action from d799045 |
harley-harris
force-pushed
the
NTRNL-281-add-jest-coverage-threshold
branch
6 times, most recently
from
bb7b1c8 to
0a33886
Compare
Mouhajer-CO
reviewed
Jan 4, 2024
.github/workflows/build-and-test.yml
Outdated
| @@ -19,3 +19,6 @@ jobs: | |||
| - run: npm ci | |||
| - run: npm run build | |||
| - run: npm test | |||
|
|
|||
| - name: Jest Coverage Report | |||
There was a problem hiding this comment.
I would have created another config file, something like
name: Jest Coverage Report
on: [pull_request]
jobs:
jest-coverage-report:
runs-on: ubuntu-latest
steps:
- name: Checkout Repository
uses: actions/checkout@v4
- name: Coverage Report
uses: ArtiomTr/jest-coverage-report-action@v2
There was a problem hiding this comment.
I had to add this to the step:
uses: actions/setup-node@v3
with:
node-version: '20.x'
as the coverage report was failing to build the report without it
There was a problem hiding this comment.
It looks good to me 👍, change the node action to latest version actions/setup-node@v4
harley-harris
force-pushed
the
NTRNL-281-add-jest-coverage-threshold
branch
5 times, most recently
from
34d42ac to
45938f7
Compare
harley-harris
force-pushed
the
NTRNL-281-add-jest-coverage-threshold
branch
from
45938f7 to
d799045
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT PR DO NOT MERGE
USED TO TEST GITHUB ACTION.
This draft PR has been preserved to keep a record of the conversation notes and to account for branch renaming, see #13 for implementation