Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post and get generic call on Node SDK Api #26

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

DanielMurray97
Copy link
Contributor

JIRA link

Resolves IDP-440

Description

  • Add get and post generic API calls.
  • Fix linting issues in mocks which break our ESlint rules

For more context on the possibilities with these changes please see the card.

Work checklist

  • Tests added where applicable
  • No vulnerability added

Copy link

github-actions bot commented Sep 13, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
97.73% (+0.11% 🔼)
86/88
🟢 Branches 85.71% 24/28
🟢 Functions
97.22% (+0.16% 🔼)
35/36
🟢 Lines
97.3% (+0.15% 🔼)
72/74

Test suite run success

26 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from c5e318f

@DanielMurray97 DanielMurray97 force-pushed the IDP-440-add-post-pr-call-on-node-sdk-api branch from 71a8463 to f22be12 Compare September 13, 2024 11:57
Copy link
Contributor

@Mouhajer-CO Mouhajer-CO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DanielMurray97 DanielMurray97 merged commit 77d5b73 into main Sep 23, 2024
7 checks passed
@DanielMurray97 DanielMurray97 deleted the IDP-440-add-post-pr-call-on-node-sdk-api branch September 23, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants