Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST DONT MERGE rename auth key in test file to fake key #22

Closed

Conversation

harley-harris
Copy link
Contributor

JIRA link

Placeholder

Description

Placeholder

Work checklist

  • Tests added where applicable
  • No vulnerability added

Copy link

github-actions bot commented May 8, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 97.62% 82/84
🟢 Branches 85.71% 24/28
🟢 Functions 97.06% 33/34
🟢 Lines 97.14% 68/70

Test suite run success

24 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from e186ac3

@@ -23,10 +23,10 @@
expect(ApiSDK).toHaveBeenCalledTimes(1);
});
test('creatApiKeyClient sets authorization key with key passed in', () => {
const key = 'some key';
createApiKeyClient(key);
const fakeKey = 'some key';

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical test

The hard-coded value "some key" is used as
authorization header
.
The hard-coded value "some key" is used as
authorization header
.
@harley-harris harley-harris deleted the fix-hard-coded-credentials-vulnerability-scan branch May 8, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant