Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ntrnl 288 fix mapping error and remove unused fields #17

Merged

Conversation

Mouhajer-CO
Copy link
Contributor

JIRA link

Resolves NTRNL-288

Description

Fix bug related to equal and greater than response status code
Update mapping to remove unused fields

Work checklist

  • Tests added where applicable
  • No vulnerability added

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
97.14% (+0.08% 🔼)
68/70
🟢 Branches
84.62% (+1.28% 🔼)
22/26
🟢 Functions 96.55% 28/29
🟢 Lines
96.55% (+0.12% 🔼)
56/58

Test suite run success

20 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 8f35486

@Mouhajer-CO Mouhajer-CO requested a review from a team January 10, 2024 16:36
@Mouhajer-CO Mouhajer-CO self-assigned this Jan 10, 2024
Copy link
Contributor

@DanielMurray97 DanielMurray97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mouhajer-CO Mouhajer-CO merged commit 15d4a60 into main Jan 10, 2024
4 checks passed
@Mouhajer-CO Mouhajer-CO deleted the feature/NTRNL-288-fix-mapping-error-and-remove-unused-fields branch January 10, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants