Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove prettier #14

Merged
merged 2 commits into from
Jan 3, 2024
Merged

remove prettier #14

merged 2 commits into from
Jan 3, 2024

Conversation

DanielMurray97
Copy link
Contributor

JIRA link

NTRNL-280

Description

  • Removed prettier as save on format can be implemented with just eslint. See here for more details.

Work checklist

  • Tests added where applicable
  • No vulnerability added

Mouhajer-CO
Mouhajer-CO approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@Mouhajer-CO Mouhajer-CO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍

Could you please fix singlequote error on index.ts file. Thanks @DanielMurray97

@DanielMurray97 DanielMurray97 merged commit 0a715c2 into main Jan 3, 2024
2 checks passed
@DanielMurray97 DanielMurray97 deleted the ntrnl-280-remove-prettier-from-node-template branch January 3, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mouhajer-CO Mouhajer-CO Mouhajer-CO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielMurray97 @Mouhajer-CO