feat(errors): handle secondary rate limit error from GitHub #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for this tool!
We have a lot of repositories in our organization and fetching stats with
org-statsresulted in GitHub's secondary rate limit1 error being returned from their API.org-statsdidn't handle this so I've put some functions to do so.The
go-githubdoesn't seem to have a struct likeSecondaryRateLimitErrorso I've created a custom one.The issue happened when fetching the review stats, but I've applied the same action to the rest of the places where the "normal" rate limit is being handled.
This is my first contribution with Go (I'm fairly new to the language) so I would appreciate any feedback you might have.
The code is heavily inspired by
go-github-ratelimit2 package.Footnotes
https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28#about-secondary-rate-limits ↩
https://github.com/gofri/go-github-ratelimit ↩