fix: map value with : in it

closes #350 Signed-off-by: Carlos Alexandro Becker <[email protected]>
caarlos0 · Dec 12, 2024 · 0cbf40b · 0cbf40b
1 parent 6f3a5c0
commit 0cbf40b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/env.go b/env.go
@@ -769,7 +769,7 @@ func handleMap(field reflect.Value, value string, sf reflect.StructField, funcMa
 
 	result := reflect.MakeMap(sf.Type)
 	for _, part := range strings.Split(value, separator) {
-		pairs := strings.Split(part, keyValSeparator)
+		pairs := strings.SplitN(part, keyValSeparator, 2)
 		if len(pairs) != 2 {
 			return newParseError(sf, fmt.Errorf(`%q should be in "key%svalue" format`, part, keyValSeparator))
 		}

diff --git a/env_test.go b/env_test.go
@@ -2310,3 +2310,15 @@ func TestIssue339(t *testing.T) {
 		isEqual(t, &newValue, cfg.StringPtr)
 	})
 }
+
+func TestIssue350(t *testing.T) {
+	t.Setenv("MAP", "url:https://foo.bar:2030")
+
+	type Config struct {
+		Map map[string]string `env:"MAP"`
+	}
+
+	var cfg Config
+	isNoErr(t, Parse(&cfg))
+	isEqual(t, map[string]string{"url": "https://foo.bar:2030"}, cfg.Map)
+}