Fix 9461 mutations api endpoint #9586
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| public String getOncotatorUniprotName() { | ||
| return oncotatorUniprotName; | ||
| } |
There was a problem hiding this comment.
@jagnathan I think we should remove all oncotator.* fields
| event.setDbSnpRs(rs.getString("DB_SNP_RS")); | ||
| event.setDbSnpValStatus(rs.getString("DB_SNP_VAL_STATUS")); |
There was a problem hiding this comment.
i think we can get rid of these as well
There was a problem hiding this comment.
So maybe remove dbSnp* and oncotator*
Also - not sure if we are using canonical transcript still? I think we might be able to remove that one as well
There was a problem hiding this comment.
Im not 100% sure about ONCOTATOR_PROTEIN_POS_START but I think it can be removed
There was a problem hiding this comment.
oncotatorProteinPosStart and oncotatorProteinPosEnd are used for sorting in MutationSortBy Enum
- modified java files to remove unused properties and changes to tests - db changes, mutationmapper.xml - Update seed_mini.sql
fix 9461 removing Oncotator related properties
jagnathan
force-pushed
the
fix-9461-mutations-api-endpoint
branch
from
c7d3da5 to
eeb85e9
Compare
fix 9461 mutations api oncotator related fields
Using 0 instead of -1 for mutPos as 0 is a valid value for position.
|
Kudos, SonarCloud Quality Gate passed! |
|
This PR has been superseded by the new PR #9817. Another PR will be created for oncotator* and dbSnp* fields |
Fix #9461