Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom sample filtering performance and security improvement #11296

Open
wants to merge 2 commits into
base: demo-rfc80-poc
Choose a base branch
from
Open

Custom sample filtering performance and security improvement #11296

wants to merge 2 commits into from
+33 −9

Conversation

dippindots
Copy link
Member

Fix #11195

  • concat has poor performance during my test, we should try to not use concat in a large foreach clause
  • clickhouse support native array in the query, and it has better performance, try replace large foreach with array

In this pull request:

  • Change back from string to prepared statement for security reason
  • Use native array to improve performance

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 18, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dippindots