Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chromoscope News #11133

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Add Chromoscope News #11133

merged 4 commits into from
Nov 1, 2024

Conversation

inodb
Copy link
Member

@inodb inodb commented Oct 28, 2024 •
edited
Loading

@inodb inodb requested review from tmazor, schultzn and jjgao October 28, 2024 21:26
tmazor
tmazor approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@tmazor tmazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Maybe mention that it's only within patient view? IIRC correctly chromoscope had a multi-sample view but we don't have that integrated, right? Or just ignore this comment if my memory is making things up.

@inodb
Copy link
Member Author

inodb commented Oct 29, 2024

Thanks @tmazor ! Good memory :)! Updated it to say Patient View

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jjgao
jjgao approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@jjgao jjgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really cool!

@inodb inodb merged commit d02df6c into master Nov 1, 2024
18 of 20 checks passed
@inodb inodb deleted the add-chromoscope-news branch November 1, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmazor tmazor tmazor approved these changes

@jjgao jjgao jjgao approved these changes

@schultzn schultzn Awaiting requested review from schultzn

Assignees
No one assigned
Labels
do not merge documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inodb @jjgao @tmazor